-
Notifications
You must be signed in to change notification settings - Fork 354
Update for Lucee 6.2 breaking change to log levels #1699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@tomchiverton thanks for this - I was a little confused when I first read your update which says "Note in Lucee 6.2 or later the default log level is ERROR, so no messages will appear by default." I had thought this meant the default type for cflog was changed to So a few suggested updates.
|
|
How do I add an engine specific note ? |
|
@tomchiverton under "engines" then "lucee", there is a key called "notes": Line 16 in b994d27
|
|
Looks like doing that last step fell between the cracks. @tomchiverton, would you want to do it (to close out your pr) or would you want one of us to proceed with a new one? BTW, guys, I don't "live" in github. If a new pr isn't necessary (for someone else to make the change), feel free to clarify. I'm just trying to help, not playing traffic cop. :-) I came on this while reviewing the Lucee breaking changes docs. Also, it seems it could be helpful to mention in the note that the new default log level for Lucee CAN be changed (rather than leaving the implication that every cflog/write log must be changed), adding a pointer to where it's discussed: https://dev.lucee.org/t/application-log-defaults-to-error-in-6-2/14773 |
|
I've spent the last half hour fighting Microsoft's website to let me edit two files, with 50% success so far :/ |
|
I think GitHub's AI infested git client has let me make the required four line change now ? |
Sorry to hear it was so painful...but think of the good karma. :-) And thanks. Pete, would you consider adding the link to that point about modifying the overall Lucee log level instead? That's an option some may prefer to changing code. But it will be as unobvious to most folks as the changed behavior that this doc tweak is noting. |
|
Thanks for updating that @tomchiverton - @carehart yep, I've updated it again to include that link. |
|
Thx. :-)
|
https://dev.lucee.org/t/application-log-defaults-to-error-in-6-2/14773